Skip to content

MCS: remove legacy servers & ports#423

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kikisdeliveryservice:remove-legacy-ports
Feb 15, 2019
Merged

MCS: remove legacy servers & ports#423
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
kikisdeliveryservice:remove-legacy-ports

Conversation

@kikisdeliveryservice
Copy link
Contributor

@kikisdeliveryservice kikisdeliveryservice commented Feb 13, 2019

legacySecureServer and legacyInsecureServer were added to accommodate the
installer port references when we transitioned the MCS ports from 49500/49501
to 22623/22624. The installer was updated via PR #1180 to use 22623/22624, so
we can now remove the legacy server/port references.

Clean-up step for: #166
Related to: #368
Related-to: openshift/installer#1180

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2019
@runcom
Copy link
Member

runcom commented Feb 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2019
@cgwalters
Copy link
Member

cgwalters commented Feb 13, 2019

This looks good to me. One minor thing, would you mind adding the "topic prefix" like MCS: as you have in the PR title (I've been using daemon:, controller: or in this case server:) into the commit message title too?

One other thing I'd note is that while it should be safe from a CI perspective to do this right now, we will break anyone who e.g. is using an older installer and trying to do a new update payload. So when we make changes like this it might be nice to wait...I dunno, a week? But eh, I'm fine doing it now.

@runcom
Copy link
Member

runcom commented Feb 13, 2019 •
edited
Loading

/lgtm cancel

due to Colin's comment above actually just to hash that out

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2019
@cgwalters
Copy link
Member

cgwalters commented Feb 13, 2019

(On the other hand, merging this will definitely fix known issues)

@ashcrow
Copy link
Member

ashcrow commented Feb 13, 2019

This looks good to me. One minor thing, would you mind adding the "topic prefix" like MCS: as you have in the PR title (I've been using daemon:, controller: or in this case server:) into the commit message title too?

👍

One other thing I'd note is that while it should be safe from a CI perspective to do this right now, we will break anyone who e.g. is using an older installer and trying to do a new update payload. So when we make changes like this it might be nice to wait...I dunno, a week? But eh, I'm fine doing it now.

I saw let's rip off the band aid now 😸

@cgwalters
Copy link
Member

cgwalters commented Feb 13, 2019

I saw let's rip off the band aid now smile_cat

Fine by me too!

@kikisdeliveryservice
Copy link
Contributor Author

kikisdeliveryservice commented Feb 13, 2019 •
edited
Loading

@cgwalters I just wanted to put the pr in now so that we wouldn't forget. I'm fine waiting too. I'll update my commit message and repush and let yall decide when it goes in. 😄

@kikisdeliveryservice
MCS: remove legacy servers & ports
2a299f1 
legacySecureServer and legacyInsecureServer were added to accomodate the
installer port references when we transitioned the MCS ports from 49500/49501
to 22623/22624. The installer was updated via PR openshift#1180 to use 22623/22624, so
we can now remove the legacy server/port references.
@kikisdeliveryservice
Copy link
Contributor Author

kikisdeliveryservice commented Feb 13, 2019

/retest

@kikisdeliveryservice
Copy link
Contributor Author

kikisdeliveryservice commented Feb 14, 2019

/test e2e-aws

@runcom
Copy link
Member

runcom commented Feb 14, 2019

/retest

@ashcrow
Copy link
Member

ashcrow commented Feb 14, 2019

Flakes

/retest

@cgwalters
Copy link
Member

cgwalters commented Feb 14, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Feb 14, 2019
Closed
@openshift-merge-robot openshift-merge-robot merged commit b387f30 into openshift:master Feb 15, 2019
@kikisdeliveryservice kikisdeliveryservice deleted the remove-legacy-ports branch February 22, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crawford crawford Awaiting requested review from crawford

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@cgwalters cgwalters

@runcom runcom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kikisdeliveryservice @runcom @cgwalters @ashcrow @openshift-ci-robot @openshift-merge-robot